Svg images created #21#23
Merged
Merged
Conversation
12 tasks
dietmarw
requested changes
Feb 11, 2020
Collaborator
dietmarw
left a comment
dietmarw
left a comment
There was a problem hiding this comment.
A couple of things.
- The
penstock.pngstill needs to be converted - I understand the issue with the colour but then we should agree on some standard colour code: My proposal is RGB={20,220,220} and then also the connector colours should be adapted.
- keep air colour green
- Some of the images have offset of fill colour and boundary e.g.,
STSimple.svgbut check others too. - When changing from png to svg also the references in the modelica code need to be updated and proper width needs to be set in addition. E.g.,
width="800"
Currently these png are still linked:
~/.workspace/OpenHPL/OpenHPL[Svgimages]$ grep -r "\\.png"
Binary file Resources/Documents/Report.docx matches
Waterway/PenstockKP.mo:<p><img src=\"modelica://OpenHPL/Resources/Images/penstock.png\" style=\"width:50%\"></p>
Waterway/BendPipe.mo:<p><img src=\"modelica://OpenHPL/Resources/Images/MinorLoss.png\"/></p>
Waterway/Pipe.mo: <p align=\"center\"><img src=\"modelica://OpenHPL/Resources/Images/pipe.png\"> </p>
Waterway/Penstock.mo:<p><img src=\"modelica://OpenHPL/Resources/Images/penstock.png\"></p>
Waterway/Penstock.mo:<p><img src=\"modelica://OpenHPL/Resources/Images/besad.png\"></p>
Functions/KP07/KPfunctions/GhostCells.mo:<p><img src=\"modelica://OpenHPL/Resources/Images/ghosts.png\"/></p>
Functions/DarcyFriction/fDarcy.mo:<p><img src=\"modelica://OpenHPL/Resources/Images/darcyf.png\"/></p>
Functions/DarcyFriction/fDarcy.mo:<p><img src=\"modelica://OpenHPL/Resources/Images/darcyf_zoomed.png\"/></p>
ElectroMech/Turbines/Turbine.mo:<img src=\"modelica://OpenHPL/Resources/Images/turbinepic.png\">
ElectroMech/Generators/SimpleGen.mo:<img src=\"modelica://OpenHPL/Resources/Images/simplegen.png\">
ElectroMech/Generators/SimpleGen2.mo:<img src=\"modelica://OpenHPL/Resources/Images/simplegen.png\">
Collaborator
|
One more:
|
Contributor
Author
|
I got the way to fix the arrow for denoting flow like Vdot, velocity-v, etc. in STSimple and others. I made changes in gitkraken, thanks for the video. Is it possible to work with Lyx rather than Latex for Userguide; I have a very slow workflow with Latex? |
Collaborator
|
No please no Lyx. |
Contributor
Author
|
OK. |
Collaborator
|
@pandeysudan27 Did you have any chance on working further on this PR fixing the issues I mentioned above? |
Collaborator
|
I've now replaced all png files except
|
This is now named turbinepelton and also displayed in the pelton turbine model
Only one remaining: wicketGateGeometry but that one does not seem to be used in the Modelica models.
dietmarw
approved these changes
Nov 6, 2020
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some svg images were created. The color code of water and air is taken lighter so that latex text can be seen easily. Otherwise its an extra job to create a background image for the latex text, probably white; I am afraid, the whole figure looks ugly. (It looks like ghosts.png was never used) . May be we need to check unused images. (@dietmarw Do you have any short method to check if all the images where used in the OpenHPL).